Jaculabilis
/
amanuensis
1
1
Fork 0
Code Issues 19 Pull Requests Projects 1 Releases Activity

Implement index assignments #22

Merged
Jaculabilis merged 4 commits from tvb/turn-assignment into develop 2021-09-22 15:25:20 +00:00
Conversation 0 Commits 4 Files Changed 13 +375 -36
Jaculabilis commented 2021-09-22 15:25:13 +00:00
Owner
Copy Link

In implementing this, I found that using the existing Sqlalchemy ORM relationships to do simple lookups like "all characters in lexicon" is easier than adding methods to the respective backend classes. I think in the spirit of "premature optimization is the root of all evil", this is a good pattern to follow for now, and the relationships can be configured to do loads in a performant way (or replaced with optimized backend queries) when that becomes the development concern.

In implementing this, I found that using the existing Sqlalchemy ORM relationships to do simple lookups like "all characters in lexicon" is easier than adding methods to the respective backend classes. I think in the spirit of "premature optimization is the root of all evil", this is a good pattern to follow for now, and the relationships can be configured to do loads in a performant way (or replaced with optimized backend queries) when that becomes the development concern.
Jaculabilis added 4 commits 2021-09-22 15:25:13 +00:00
0d022af335 Implement index assignments 
The index assignment UI uses the same table-form pattern as the index
UI. There is currently no control over deleting indices when an index
assignment exists on that index.
Jaculabilis merged commit 0d022af335 into develop 2021-09-22 15:25:20 +00:00
Jaculabilis deleted branch tvb/turn-assignment 2021-09-22 15:25:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Something's broken

  
Enhancement

Not on the critical path

  
Feature

Critical path for a workflow

  
Parity

Feature in v0.1

No Label
Bug
Enhancement
Feature
Parity
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Jaculabilis/amanuensis#22
No description provided.
Delete Branch "tvb/turn-assignment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?