Unified deactivate command

cmd/itemDeactivate.go

@@ -10,34 +10,42 @@ import (
 )
 
 var itemDeactivateCmd = &cobra.Command{
-	Use:     "deactivate",
+	Use:     "deactivate --source source [--item item]",
 	Aliases: []string{"deac"},
-	Short:   "Deactivate an item",
+	Short:   "Deactivate items",
 	Long: `Deactivate items, hiding them from feeds and marking them for deletion.
 
 Deactivation is idempotent.`,
 	Run: func(cmd *cobra.Command, args []string) {
 		itemDeactivate(stringArg(cmd, "source"), stringArg(cmd, "item"))
 	},
+	DisableFlagsInUseLine: true,
 }
 
 func init() {
-	itemCmd.AddCommand(itemDeactivateCmd)
+	rootCmd.AddCommand(itemDeactivateCmd)
 
 	itemDeactivateCmd.Flags().StringP("source", "s", "", "Source of the item")
 	itemDeactivateCmd.MarkFlagRequired("source")
 	itemDeactivateCmd.Flags().StringP("item", "i", "", "Item id")
-	itemDeactivateCmd.MarkFlagRequired("item")
 }
 
 func itemDeactivate(source string, item string) {
+	if source == "" {
+		log.Fatal("error: --source is empty")
+	}
+
 	db := openAndMigrateDb()
 
-	active, err := core.DeactivateItem(db, source, item)
-	if err != nil {
-		log.Fatalf("Failed to deactivate item: %s", err)
-	}
-	if active {
-		fmt.Printf("Deactivated %s/%s\n", source, item)
+	if item == "" {
+		log.Fatal("source deactivation is not implemented")
+	} else {
+		active, err := core.DeactivateItem(db, source, item)
+		if err != nil {
+			log.Fatalf("Failed to deactivate item: %s", err)
+		}
+		if active {
+			fmt.Printf("Deactivated %s/%s\n", source, item)
+		}
 	}
 }

cmd/sourceDeactivate.go

@@ -1,21 +0,0 @@
-package cmd
-
-import (
-	"log"
-
-	"github.com/spf13/cobra"
-)
-
-var sourceDeactivateCmd = &cobra.Command{
-	Use:   "deactivate",
-	Short: "Deactivate all items in a source",
-	Long: `
-`,
-	Run: func(cmd *cobra.Command, args []string) {
-		log.Fatal("not implemented")
-	},
-}
-
-func init() {
-	sourceCmd.AddCommand(sourceDeactivateCmd)
-}